This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Venv Telemetry and Structure Refactoring#240
Merged
Merged
Conversation
Contributor
|
Would be nice to have venv as a service where you would only set telemetry ai once as an attribute |
nasadigital
reviewed
Mar 5, 2020
xnkevinnguyen
approved these changes
Mar 5, 2020
Contributor
xnkevinnguyen
left a comment
There was a problem hiding this comment.
Nice work! Will be nice to have telemetry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adding telemetry to the new venv setup process merged in #218 .
EDIT: also re-structured setup code. Now, the code for setup is abstracted into a SetupService object. The telemetryAI object is now passed in within the SetupService constructor and setupEnv is called whenever the setup process needs to be triggered.
Type of change
Testing:
Tested setup process (common flows)
Checklist:
npm run formatand passes the checks innpm run check