Fix failing "Tests (windows-latest, 3.10)" CI job by pinning Windows runner to windows-2022#1057
Open
dependabot[bot] wants to merge 2 commits into
Open
Fix failing "Tests (windows-latest, 3.10)" CI job by pinning Windows runner to windows-2022#1057dependabot[bot] wants to merge 2 commits into
dependabot[bot] wants to merge 2 commits into
Conversation
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.1 to 4.2.0. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.1...4.2.0) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.2.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
rzhao271
previously approved these changes
Jun 22, 2026
connor4312
previously approved these changes
Jun 22, 2026
Copilot
AI
changed the title
Bump js-yaml from 4.1.1 to 4.2.0
Fix failing "Tests (windows-latest, 3.10)" CI job by pinning Windows runner to windows-2022
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI job "Tests (windows-latest, 3.10)" was failing because
windows-latestnow resolves towindows-2025, which ships with Visual Studio 2025 (major version 18). Thenode-gypv11.0.0 (bundled with npm on Node 22) does not recognize VS version 18, causing the native module@vscode/windows-process-treeto fail to compile duringnpm ci.Root Cause
node-gyp v11 only recognizes Visual Studio up to version 17 (VS 2022). The
windows-2025runner provides VS 2025 (version 18), which node-gyp reports as"undefined"and skips.Fix
Pinned the Windows runner from
windows-latesttowindows-2022in bothpr-check.ymlandpush-check.yml. Thewindows-2022runner provides Visual Studio 2022 (version 17), which node-gyp v11 correctly identifies and uses for compiling native modules.