Skip to content

Add smoke tests to GH Action#9964

Merged
kimadeline merged 79 commits into
microsoft:masterfrom
kimadeline:gh-action-smoke
Feb 7, 2020
Merged

Add smoke tests to GH Action#9964
kimadeline merged 79 commits into
microsoft:masterfrom
kimadeline:gh-action-smoke

Conversation

@kimadeline
Copy link
Copy Markdown

@kimadeline kimadeline commented Feb 6, 2020

For #9842

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

Kim-Adeline Miguel and others added 30 commits February 5, 2020 10:12
Update branch name (for testing)
52ed050
TypeScript tests
6d44a0c
python unit tests
75f40d6
ipython unit tests
b574982
single, multi, debugger tests
2f23828
functional tests
62d37de
Comment out VSIX build+upload when testing the action
8c382c3
Cache out/ directory
e0a276c
rename step id to more specific pythonFiles
d02b67d
single workspace tests
253945f
multi workspace tests
5b9b8e0
debugger tests
f2c99d4
Add todo for when the PR is ready for review
b88f081
Fix out/ cache key
642fa26
Fix pythonFiles cache key
51f5316
Retry single workspace tests
c030545
Use same cache key everywhere
5df18b3
Try out multi workspace tests
7bac289
Try out debugger tests
d2d07e8
Uncomment compile + upload step
bca6632
run venv tests
7304c1f
Update branch name to trigger workflow
d837d95
Adding comments + enable full test suite
bdc9528
Finalize versions of python we want to use
af5adb8
Try 3.7 instead of 3.8
da1b3bc
Run the workflow only on upstream master
711da52
Clean up comments
234e049
Revert to 3.8
4c3a2ef
@kimadeline @brettcannon
Update .github/workflows/ci.yml
66617c5 
Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>
@kimadeline @brettcannon
Apply suggestions from code review
3c68d59 
Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>
@kimadeline kimadeline marked this pull request as ready for review February 7, 2020 00:43
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kimadeline kimadeline merged commit 0f65671 into microsoft:master Feb 7, 2020
@kimadeline kimadeline deleted the gh-action-smoke branch February 7, 2020 23:31
@lock lock Bot locked as resolved and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@brettcannon brettcannon brettcannon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kimadeline @codecov-io @brettcannon