Skip to content

Start running CI using a GitHub Action: build, compile, hygiene, check deps#9843

Merged
kimadeline merged 28 commits into
microsoft:masterfrom
kimadeline:gh-action-ci
Feb 5, 2020
Merged

Start running CI using a GitHub Action: build, compile, hygiene, check deps#9843
kimadeline merged 28 commits into
microsoft:masterfrom
kimadeline:gh-action-ci

Conversation

@kimadeline
Copy link
Copy Markdown

@kimadeline kimadeline commented Jan 30, 2020

First PR for #9842 (others will come for running tests, smoke tests and report coverage)

This PR includes:

  • build the extension
  • hygiene (linting + formatting)
  • package vsix and save it as an artifact (❓ is it necessary?)
  • check dependencies
  • adding YAML-specific prettier config

@kimadeline kimadeline added the no-changelog No news entry required label Jan 30, 2020
@kimadeline kimadeline marked this pull request as ready for review January 30, 2020 23:26
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 30, 2020

Codecov Report

Merging #9843 into master will decrease coverage by <.01%.
The diff coverage is 60.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9843      +/-   ##
==========================================
- Coverage   61.22%   61.21%   -0.01%     
==========================================
  Files         563      564       +1     
  Lines       30058    30061       +3     
  Branches     4545     4545              
==========================================
  Hits        18403    18403              
- Misses      10626    11447     +821     
+ Partials     1029      211     -818
Impacted Files Coverage Δ
src/client/common/serviceRegistry.ts 100% <ø> (ø) ⬆️
src/client/activation/types.ts 100% <ø> (ø) ⬆️
src/client/common/platform/types.ts 100% <ø> (ø) ⬆️
...c/client/activation/common/downloadChannelRules.ts 100% <ø> (ø) ⬆️
src/client/common/types.ts 100% <ø> (ø) ⬆️
.../datascience/interactive-common/interactiveBase.ts 16.96% <0%> (ø) ⬆️
.../application/diagnostics/applicationDiagnostics.ts 94.87% <100%> (ø) ⬆️
...ent/interpreter/locators/services/pipEnvService.ts 82.97% <100%> (ø) ⬆️
src/client/activation/languageServer/activator.ts 100% <100%> (ø) ⬆️
src/client/activation/languageServer/manager.ts 82.75% <100%> (ø) ⬆️
... and 240 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4eefd...5ebabef. Read the comment docs.

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
run: npm ci

- name: Run gulp prePublishNonBundle
run: npx gulp prePublishNonBundle
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this step different than the compile necessary for the VSIX bundling since the results here are not cached?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compile step for the VSIX runs npx gulp prePublishBundle, while this one is prePublishNonBundle. Behind the scenes they call:

gulp.task('prePublishBundle', gulp.series('webpack', 'renameSourceMaps'));
gulp.task('prePublishNonBundle', gulp.series('compile', 'compile-webviews'));

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kimadeline kimadeline merged commit 92cf27a into microsoft:master Feb 5, 2020
@kimadeline kimadeline deleted the gh-action-ci branch February 5, 2020 06:02
@kimadeline kimadeline mentioned this pull request Feb 5, 2020
5 tasks
@lock lock Bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants