Start running CI using a GitHub Action: build, compile, hygiene, check deps#9843
Merged
Conversation
added 13 commits
January 30, 2020 10:42
Codecov Report
@@ Coverage Diff @@
## master #9843 +/- ##
==========================================
- Coverage 61.22% 61.21% -0.01%
==========================================
Files 563 564 +1
Lines 30058 30061 +3
Branches 4545 4545
==========================================
Hits 18403 18403
- Misses 10626 11447 +821
+ Partials 1029 211 -818
Continue to review full report at Codecov.
|
brettcannon
suggested changes
Jan 31, 2020
| run: npm ci | ||
|
|
||
| - name: Run gulp prePublishNonBundle | ||
| run: npx gulp prePublishNonBundle |
Member
There was a problem hiding this comment.
How is this step different than the compile necessary for the VSIX bundling since the results here are not cached?
Author
There was a problem hiding this comment.
The compile step for the VSIX runs npx gulp prePublishBundle, while this one is prePublishNonBundle. Behind the scenes they call:
gulp.task('prePublishBundle', gulp.series('webpack', 'renameSourceMaps'));
gulp.task('prePublishNonBundle', gulp.series('compile', 'compile-webviews'));
added 11 commits
February 3, 2020 14:17
|
Kudos, SonarCloud Quality Gate passed!
|
brettcannon
approved these changes
Feb 5, 2020
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR for #9842 (others will come for running tests, smoke tests and report coverage)
This PR includes: