Skip to content

Format Python files with Black#9742

Merged
kimadeline merged 3 commits into
masterfrom
2012-format-python-black
Jan 24, 2020
Merged

Format Python files with Black#9742
kimadeline merged 3 commits into
masterfrom
2012-format-python-black

Conversation

@kimadeline
Copy link
Copy Markdown

@kimadeline kimadeline commented Jan 23, 2020

For #2012

  • Format Python files with Black, exclude test data.
  • Pipeline support will be added in a separate PR
  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Jan 23, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 23, 2020 •
edited
Loading

Codecov Report

Merging #9742 into master will decrease coverage by 0.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9742      +/-   ##
==========================================
- Coverage   60.64%   59.87%   -0.78%     
==========================================
  Files         552      552              
  Lines       29778    31100    +1322     
  Branches     4505     4931     +426     
==========================================
+ Hits        18060    18620     +560     
- Misses      10706    11412     +706     
- Partials     1012     1068      +56
Impacted Files Coverage Δ
src/client/common/terminal/factory.ts 89.13% <0%> (-7.3%) ⬇️
src/client/common/asyncDisposableRegistry.ts 18.18% <0%> (-4.05%) ⬇️
src/client/common/terminal/service.ts 88.7% <0%> (-4.02%) ⬇️
...atascience/interactive-window/interactiveWindow.ts 16.57% <0%> (-2.09%) ⬇️
...ascience/jupyter/liveshare/guestJupyterNotebook.ts 8.16% <0%> (-2.03%) ⬇️
src/client/testing/main.ts 13.67% <0%> (-1.12%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 3.61% <0%> (-0.99%) ⬇️
src/client/common/terminal/syncTerminalService.ts 82.1% <0%> (-0.04%) ⬇️
.../datascience/interactive-common/interactiveBase.ts 19.04% <0%> (-0.02%) ⬇️
src/client/common/terminal/types.ts 100% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410309e...b8ca7db. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kimadeline kimadeline marked this pull request as ready for review January 24, 2020 17:46
@kimadeline kimadeline merged commit a58eeff into master Jan 24, 2020
@kimadeline kimadeline deleted the 2012-format-python-black branch January 24, 2020 18:05
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

1 more reviewer

@karrtikr karrtikr karrtikr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kimadeline @codecov-io @karrtikr