Skip to content

Sort using the processName key instead of label#9411

Merged
kimadeline merged 3 commits into
microsoft:masterfrom
kimadeline:8701-sorting-processName
Jan 7, 2020
Merged

Sort using the processName key instead of label#9411
kimadeline merged 3 commits into
microsoft:masterfrom
kimadeline:8701-sorting-processName

Conversation

@kimadeline

@kimadeline kimadeline commented Jan 6, 2020

Copy link
Copy Markdown

For #8701

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Jan 6, 2020
@kimadeline kimadeline mentioned this pull request Jan 6, 2020
Closed
@kimadeline kimadeline marked this pull request as ready for review January 6, 2020 23:46
@codecov-io

codecov-io commented Jan 6, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #9411 into master will increase coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9411      +/-   ##
==========================================
+ Coverage   60.77%   60.77%   +<.01%     
==========================================
  Files         550      550              
  Lines       28779    28781       +2     
  Branches     4356     4356              
==========================================
+ Hits        17490    17493       +3     
  Misses      10338    10338              
+ Partials      951      950       -1
Impacted Files Coverage Δ
...ugger/extension/attachQuickPick/psProcessParser.ts 100% <ø> (ø) ⬆️
...client/debugger/extension/attachQuickPick/types.ts 100% <ø> (ø) ⬆️
...ger/extension/attachQuickPick/wmicProcessParser.ts 100% <100%> (ø) ⬆️
...ent/debugger/extension/attachQuickPick/provider.ts 97.5% <80%> (ø) ⬆️
...rc/client/common/process/pythonExecutionFactory.ts 97.77% <0%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ca8fc8...4293eb8. Read the comment docs.

DonJayamanne
DonJayamanne approved these changes Jan 7, 2020
View reviewed changes
Comment thread src/client/debugger/extension/attachQuickPick/provider.ts Outdated
@kimadeline kimadeline merged commit de0deba into microsoft:master Jan 7, 2020
@kimadeline kimadeline deleted the 8701-sorting-processName branch January 7, 2020 16:31
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kimadeline @codecov-io @DonJayamanne