Pass flag to PTVSD to ensure file path case sensitivity is preserved - #936
Merged
Don Jayamanne (DonJayamanne) merged 3 commits intoMar 5, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #936 +/- ##
==========================================
- Coverage 64.03% 64.01% -0.02%
==========================================
Files 260 260
Lines 12025 12028 +3
Branches 2131 2131
==========================================
Hits 7700 7700
- Misses 4316 4319 +3
Partials 9 9
Continue to review full report at Codecov.
|
Mikhail Arkhipov (MikhailArkhipov)
approved these changes
Mar 4, 2018
Brett Cannon (brettcannon)
approved these changes
Mar 5, 2018
Brett Cannon (brettcannon)
requested changes
Mar 5, 2018
|
|
||
| // Send PTVSD a bogus launch request, and wait for it to respond. | ||
| // This needs to be done, so PTVSD can keep track of how it was launched (whether it as for attach or launch). | ||
| const launcRequest = await this.launchRequest; |
There was a problem hiding this comment.
"launchRequest"
| // This needs to be done, so PTVSD can keep track of how it was launched (whether it as for attach or launch). | ||
| const launcRequest = await this.launchRequest; | ||
| (launcRequest.arguments as any).fixFilePathCase = this.serviceContainer.get<IPlatformService>(IPlatformService).isWindows; | ||
| this.sendMessage(await this.launchRequest, this.ptvsdSocket); |
There was a problem hiding this comment.
Pass "launchRequest" instead of await this.launchRequest
Brett Cannon (brettcannon)
approved these changes
Mar 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #935