Format ts code using Prettier#9359
Merged
Merged
Conversation
Author
|
@kimadeline created a new PR as I was having a few problems with the other branch (I had to close rebase and delete the old branch. GitHub lost links, and went looney after that) |
karthiknadig
approved these changes
Jan 2, 2020
Member
|
I had discussed this change with @DonJayamanne prior. @DonJayamanne thanks for doing this :) |
Codecov Report
@@ Coverage Diff @@
## master #9359 +/- ##
==========================================
+ Coverage 59.97% 60.33% +0.35%
==========================================
Files 545 545
Lines 28662 28668 +6
Branches 4338 4345 +7
==========================================
+ Hits 17191 17296 +105
+ Misses 10535 10443 -92
+ Partials 936 929 -7
Continue to review full report at Codecov.
|
kimadeline
approved these changes
Jan 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2012
settings.jsonensureprettieris used to format code as it is written.tslintandeslintconfiguration files to ensure prettier respects/uses existing linter settings.package.jsonnew npm packages for prettierprettier, not by hand)(I'd consider #2012 an epic as there are plenty of proposed changes, format python, js, json, css, Ci changes, etc).
Not submitting individual PRs, as I don't see any real benefit as these are changes made by a tool and not by hand. If required I can submit individual PRs for 100 files or so (that would break it into 11 PRs, thats' large).
Summary: