Skip to content

End tests reliabily on CI#9348

Merged
karrtikr merged 2 commits into
microsoft:masterfrom
karrtikr:failOnErrorCI
Dec 31, 2019
Merged

End tests reliabily on CI#9348
karrtikr merged 2 commits into
microsoft:masterfrom
karrtikr:failOnErrorCI

Conversation

@karrtikr

Copy link
Copy Markdown

For #9329

@karrtikr karrtikr added the no-changelog No news entry required label Dec 31, 2019
@codecov-io

codecov-io commented Dec 31, 2019

Copy link
Copy Markdown

Codecov Report

Merging #9348 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9348   +/-   ##
=======================================
  Coverage   60.32%   60.32%           
=======================================
  Files         544      544           
  Lines       28594    28594           
  Branches     4330     4330           
=======================================
  Hits        17248    17248           
+ Misses      10415    10408    -7     
- Partials      931      938    +7
Impacted Files Coverage Δ
src/client/common/utils/version.ts 81.48% <0%> (ø) ⬆️
.../client/datascience/jupyter/jupyterConnectError.ts 75% <0%> (ø) ⬆️
src/client/datascience/cellFactory.ts 71.25% <0%> (ø) ⬆️
src/client/language/characters.ts 94.28% <0%> (ø) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (ø) ⬆️
src/client/constants.ts 80% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b8a603...47da14a. Read the comment docs.

@DonJayamanne DonJayamanne left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can log errors (with exception and messages) in one line.
They support multiple args.

Comment thread src/test/debuggerTest.ts Outdated
Comment thread src/test/debuggerTest.ts Outdated
Comment thread src/test/multiRootTest.ts Outdated
Comment thread src/test/multiRootTest.ts Outdated
Comment thread src/test/testBootstrap.ts Outdated
Comment thread src/test/testBootstrap.ts Outdated
@karrtikr
karrtikr merged commit 38122f3 into microsoft:master Dec 31, 2019
@karrtikr
karrtikr deleted the failOnErrorCI branch December 31, 2019 22:48
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants