Move liveshare into datascience - #9296
Merged
Merged
Conversation
Kartik Raj (karrtikr)
requested review from
Don Jayamanne (DonJayamanne),
Karthik Nadig (karthiknadig) and
Rich Chiodo (rchiodo)
and removed request for
Don Jayamanne (DonJayamanne)
December 25, 2019 08:59
Codecov Report
@@ Coverage Diff @@
## master #9296 +/- ##
==========================================
- Coverage 60.32% 60.03% -0.29%
==========================================
Files 544 544
Lines 28594 28594
Branches 4330 4325 -5
==========================================
- Hits 17248 17167 -81
- Misses 10408 10489 +81
Partials 938 938
Continue to review full report at Codecov.
|
Karthik Nadig (karthiknadig)
approved these changes
Dec 27, 2019
Kartik Raj (karrtikr)
force-pushed
the
liveshare
branch
from
December 30, 2019 02:56
8589374 to
bb03763
Compare
Kartik Raj (karrtikr)
requested review from
Don Jayamanne (DonJayamanne) and
Rich Chiodo (rchiodo)
and removed request for
Don Jayamanne (DonJayamanne) and
Rich Chiodo (rchiodo)
December 30, 2019 17:38
Don Jayamanne (DonJayamanne)
approved these changes
Dec 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAICS core extension has nothing to do with liveshare. It also is misleading when we are trying to measure the code coverage for the extension by checking code coverage for
client.Can we also move
datascienceout ofclientand place it besidesdatascience-ui? Any objections Don Jayamanne (@DonJayamanne) Rich Chiodo (@rchiodo) ?cc Brett Cannon (@brettcannon)
#9231