Skip to content

Faster tests with fake timers#9272

Merged
DonJayamanne merged 2 commits into
microsoft:masterfrom
DonJayamanne:timers
Dec 23, 2019
Merged

Faster tests with fake timers#9272
DonJayamanne merged 2 commits into
microsoft:masterfrom
DonJayamanne:timers

Conversation

@DonJayamanne

@DonJayamanne DonJayamanne commented Dec 23, 2019

Copy link
Copy Markdown

Faster tests with fake timers.
Speed up tests that have Sleep(n)

Speed up of tests from 10s to 54ms with two easy lines (install & wait)

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Dec 23, 2019
@codecov-io

codecov-io commented Dec 23, 2019

Copy link
Copy Markdown

Codecov Report

Merging #9272 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9272      +/-   ##
==========================================
- Coverage   57.78%   57.46%   -0.32%     
==========================================
  Files         557      557              
  Lines       29590    29590              
  Branches     4474     4468       -6     
==========================================
- Hits        17098    17004      -94     
- Misses      11548    11642      +94     
  Partials      944      944
Impacted Files Coverage Δ
src/client/testing/serviceRegistry.ts 49.09% <0%> (-47.28%) ⬇️
src/client/testing/codeLenses/main.ts 40% <0%> (-30%) ⬇️
src/datascience-ui/interactive-common/tokenizer.ts 35% <0%> (-30%) ⬇️
src/client/datascience/jupyter/jupyterUtils.ts 64.7% <0%> (-29.42%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 50% <0%> (-25%) ⬇️
src/client/formatters/serviceRegistry.ts 75% <0%> (-25%) ⬇️
src/datascience-ui/native-editor/redux/store.ts 75% <0%> (-25%) ⬇️
src/datascience-ui/history-react/redux/store.ts 75% <0%> (-25%) ⬇️
src/datascience-ui/react-common/arePathsSame.ts 37.5% <0%> (-25%) ⬇️
...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts 60% <0%> (-20%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2ca78...c49e719. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 42bd4f2 into microsoft:master Dec 23, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 1, 2020
@DonJayamanne DonJayamanne deleted the timers branch April 30, 2020 17:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants