Skip to content

Attach to process quick pick - Windows support#9249

Merged
kimadeline merged 11 commits into
microsoft:masterfrom
kimadeline:8701-windows-process-picker
Jan 2, 2020
Merged

Attach to process quick pick - Windows support#9249
kimadeline merged 11 commits into
microsoft:masterfrom
kimadeline:8701-windows-process-picker

Conversation

@kimadeline

@kimadeline kimadeline commented Dec 20, 2019 •
edited
Loading

Copy link
Copy Markdown

For #8701

Todo:

  • Add unit tests for Windows
  • Verify that it works on Windows
  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Dec 20, 2019
@codecov-io

codecov-io commented Dec 20, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #9249 into master will increase coverage by 0.03%.
The diff coverage is 98.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9249      +/-   ##
==========================================
+ Coverage   60.32%   60.35%   +0.03%     
==========================================
  Files         544      544              
  Lines       28594    28619      +25     
  Branches     4330     4339       +9     
==========================================
+ Hits        17248    17272      +24     
  Misses      10408    10408              
- Partials      938      939       +1
Impacted Files Coverage Δ
...client/debugger/extension/attachQuickPick/types.ts 100% <ø> (ø) ⬆️
...ient/debugger/extension/attachQuickPick/factory.ts 100% <100%> (ø) ⬆️
...ent/debugger/extension/attachQuickPick/provider.ts 100% <100%> (ø)
src/client/debugger/extension/adapter/activator.ts 100% <100%> (ø) ⬆️
...ugger/extension/attachQuickPick/psProcessParser.ts 100% <100%> (ø) ⬆️
...ger/extension/attachQuickPick/wmicProcessParser.ts 97.14% <97.14%> (ø)
src/client/common/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/liveshare/liveshareProxy.ts
src/client/common/liveshare/serviceProxy.ts
src/client/common/liveshare/liveshare.ts
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec90eff...22c913e. Read the comment docs.

@kimadeline kimadeline marked this pull request as ready for review December 31, 2019 22:01
@kimadeline kimadeline merged commit ea254b5 into microsoft:master Jan 2, 2020
@kimadeline kimadeline deleted the 8701-windows-process-picker branch January 2, 2020 16:03
@kimadeline kimadeline mentioned this pull request Jan 6, 2020
Closed
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kimadeline @codecov-io @karthiknadig