Skip to content

Fix broken debugger tests due to missing IFileSystem#9189

Merged
DonJayamanne merged 1 commit into
microsoft:masterfrom
DonJayamanne:fixDebugTests
Dec 18, 2019
Merged

Fix broken debugger tests due to missing IFileSystem#9189
DonJayamanne merged 1 commit into
microsoft:masterfrom
DonJayamanne:fixDebugTests

Conversation

@DonJayamanne

@DonJayamanne DonJayamanne commented Dec 18, 2019 •
edited
Loading

Copy link
Copy Markdown

For #8882
For #8895

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Dec 18, 2019
@codecov-io

codecov-io commented Dec 18, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #9189 into master will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9189      +/-   ##
==========================================
+ Coverage    56.8%   57.14%   +0.34%     
==========================================
  Files         550      550              
  Lines       28938    29308     +370     
  Branches     4441     4435       -6     
==========================================
+ Hits        16438    16749     +311     
- Misses      11560    11619      +59     
  Partials      940      940
Impacted Files Coverage Δ
src/client/testing/serviceRegistry.ts 49.09% <0%> (-42.14%) ⬇️
src/client/datascience/jupyter/jupyterUtils.ts 64.7% <0%> (-18.63%) ⬇️
src/datascience-ui/interactive-common/tokenizer.ts 35% <0%> (-5%) ⬇️
src/client/providers/providerUtilities.ts 83.33% <0%> (-3.34%) ⬇️
src/client/api.ts 78.57% <0%> (-3.25%) ⬇️
src/client/testing/codeLenses/main.ts 40% <0%> (-2.86%) ⬇️
src/datascience-ui/native-editor/redux/actions.ts 6.97% <0%> (-0.35%) ⬇️
src/datascience-ui/history-react/redux/actions.ts 6.45% <0%> (-0.22%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 50% <0%> (ø) ⬆️
...lient/datascience/jupyter/jupyterSelfCertsError.ts 100% <0%> (ø) ⬆️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbddaf9...9d23aba. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 2d22fff into microsoft:master Dec 18, 2019
DonJayamanne added a commit that referenced this pull request Dec 18, 2019
@DonJayamanne
Fix broken debugger tests due to missing IFileSystem (#9189)
813c20b
@ericsnowcurrently

ericsnowcurrently commented Dec 19, 2019

Copy link
Copy Markdown

Thanks for taking care of this, @DonJayamanne!

@lock lock Bot locked as resolved and limited conversation to collaborators Dec 26, 2019
@DonJayamanne DonJayamanne deleted the fixDebugTests branch April 30, 2020 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rchiodo rchiodo rchiodo approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DonJayamanne @codecov-io @ericsnowcurrently @rchiodo