Add support for folding of docstrings and comments#894
Merged
Conversation
| @@ -0,0 +1,65 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
There was a problem hiding this comment.
I'd also add basic tests - empty file, unclosed string, odd sequences like """ s1 """ """ s2 """ without like breaks
Author
There was a problem hiding this comment.
Easy, will do.
I think unclosed strings will be treated as strings by tokenizer, wouldn't it.
There was a problem hiding this comment.
Yes, it is more how folding code calculates 'next' line position when there may be none
MikhailArkhipov
approved these changes
Feb 25, 2018
Codecov Report
@@ Coverage Diff @@
## master #894 +/- ##
==========================================
- Coverage 71.65% 54.1% -17.55%
==========================================
Files 273 275 +2
Lines 12700 12745 +45
Branches 2282 2288 +6
==========================================
- Hits 9100 6896 -2204
- Misses 3465 5698 +2233
- Partials 135 151 +16
Continue to review full report at Codecov.
|
Closed
3001d69 to
554c1c0
Compare
e451007 to
6582209
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #893
Unit tests will fail, as the API is not yet available in standard build of VS Code.
Either way, please review.