Skip to content

Expose api to get display list of interpreters#8868

Merged
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:exposeSelection
Dec 3, 2019
Merged

Expose api to get display list of interpreters#8868
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:exposeSelection

Conversation

@DonJayamanne
Copy link
Copy Markdown

For #8612

Expose existing API as public method via interface

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Dec 3, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 3, 2019

Codecov Report

Merging #8868 into master will increase coverage by 0.33%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8868      +/-   ##
==========================================
+ Coverage   57.63%   57.97%   +0.33%     
==========================================
  Files         527      527              
  Lines       27480    27512      +32     
  Branches     4126     4141      +15     
==========================================
+ Hits        15839    15950     +111     
+ Misses      10770    10690      -80     
- Partials      871      872       +1
Impacted Files Coverage Δ
src/client/interpreter/configuration/types.ts 100% <ø> (ø) ⬆️
...t/interpreter/configuration/interpreterSelector.ts 64.7% <100%> (ø) ⬆️
...science/jupyter/liveshare/guestJupyterExecution.ts 18.96% <0%> (ø) ⬆️
...ent/datascience/data-viewing/dataViewerProvider.ts 23.07% <0%> (ø) ⬆️
src/client/datascience/jupyter/jupyterExecution.ts 55.26% <0%> (ø) ⬆️
...ascience/jupyter/liveshare/hostJupyterExecution.ts 48.33% <0%> (ø) ⬆️
src/client/common/types.ts 100% <0%> (ø) ⬆️
src/client/datascience/constants.ts 99.66% <0%> (ø) ⬆️
...ent/datascience/jupyter/jupyterExecutionFactory.ts 64.51% <0%> (+0.58%) ⬆️
src/client/language/characters.ts 37.14% <0%> (+2.85%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0fbdfd...6093bcd. Read the comment docs.

@DonJayamanne DonJayamanne merged commit d84a11e into microsoft:master Dec 3, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 10, 2019
@DonJayamanne DonJayamanne deleted the exposeSelection branch December 17, 2019 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants