Skip to content

Update file metadata with notebook interpreter and kernel info#8835

Merged
IanMatthewHuff merged 8 commits into
microsoft:masterfrom
IanMatthewHuff:dev/ianhu/kernelMetadata
Dec 2, 2019
Merged

Update file metadata with notebook interpreter and kernel info#8835
IanMatthewHuff merged 8 commits into
microsoft:masterfrom
IanMatthewHuff:dev/ianhu/kernelMetadata

Conversation

@IanMatthewHuff

@IanMatthewHuff IanMatthewHuff commented Nov 27, 2019

Copy link
Copy Markdown
Member

For #8223

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

IanMatthewHuff
IanMatthewHuff commented Nov 27, 2019
View reviewed changes
Comment thread src/client/datascience/types.ts
IanMatthewHuff
IanMatthewHuff commented Nov 27, 2019
View reviewed changes
Comment thread src/test/datascience/interactive-ipynb/nativeEditor.unit.test.ts
@IanMatthewHuff IanMatthewHuff requested review from DavidKutu, DonJayamanne and rchiodo and removed request for DonJayamanne November 27, 2019 22:00
rchiodo
rchiodo approved these changes Nov 27, 2019
View reviewed changes

@rchiodo rchiodo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

IanMatthewHuff
IanMatthewHuff commented Nov 27, 2019
View reviewed changes
Comment thread src/client/datascience/interactive-ipynb/nativeEditor.ts
DonJayamanne
DonJayamanne reviewed Nov 27, 2019
View reviewed changes
Comment thread src/client/datascience/jupyter/jupyterNotebook.ts
Comment thread src/test/datascience/nativeEditor.functional.test.tsx Outdated
Comment thread src/client/datascience/interactive-ipynb/nativeEditor.ts Outdated
@codecov-io

codecov-io commented Dec 2, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8835 into master will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8835      +/-   ##
==========================================
- Coverage   58.68%   58.39%   -0.29%     
==========================================
  Files         526      526              
  Lines       27231    27242      +11     
  Branches     4064     4067       +3     
==========================================
- Hits        15980    15908      -72     
- Misses      10372    10468      +96     
+ Partials      879      866      -13
Impacted Files Coverage Δ
...t/datascience/jupyter/kernels/jupyterKernelSpec.ts 83.33% <ø> (ø) ⬆️
src/client/datascience/types.ts 100% <ø> (ø) ⬆️
...ascience/jupyter/liveshare/guestJupyterNotebook.ts 10.75% <0%> (-0.24%) ⬇️
...ient/datascience/interactive-ipynb/nativeEditor.ts 54.18% <0%> (-8.48%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 5.26% <0%> (-0.03%) ⬇️
.../datascience/interactive-common/interactiveBase.ts 18.67% <0%> (-6.77%) ⬇️
src/client/datascience/webViewHost.ts 51.18% <0%> (-1.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee819a...fcd9810. Read the comment docs.

DonJayamanne
DonJayamanne requested changes Dec 2, 2019
View reviewed changes
Comment thread src/test/datascience/interactive-ipynb/nativeEditor.unit.test.ts
DonJayamanne
DonJayamanne requested changes Dec 2, 2019
View reviewed changes
Comment thread src/client/datascience/interactive-ipynb/nativeEditor.ts Outdated
Comment thread src/client/datascience/interactive-ipynb/nativeEditor.ts Outdated
@IanMatthewHuff IanMatthewHuff merged commit d0fbdfd into microsoft:master Dec 2, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 9, 2019
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/kernelMetadata branch July 9, 2020 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes
@rchiodo rchiodo rchiodo approved these changes
+1 more reviewer
@DavidKutu DavidKutu DavidKutu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IanMatthewHuff @codecov-io @DonJayamanne @rchiodo @DavidKutu