Skip to content

Fix CI tests failing because of the conda run PR#8730

Merged
kimadeline merged 1 commit into
microsoft:masterfrom
kimadeline:8727-conda-run-multi-workspace-tests
Nov 22, 2019
Merged

Fix CI tests failing because of the conda run PR#8730
kimadeline merged 1 commit into
microsoft:masterfrom
kimadeline:8727-conda-run-multi-workspace-tests

Conversation

@kimadeline

@kimadeline kimadeline commented Nov 22, 2019

Copy link
Copy Markdown

For #8727

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Nov 22, 2019
@kimadeline kimadeline changed the title Fix CI tests failing because of he conda run PR Fix CI tests failing because of the conda run PR Nov 22, 2019
@codecov-io

codecov-io commented Nov 22, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8730 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8730   +/-   ##
=======================================
  Coverage   58.68%   58.68%           
=======================================
  Files         527      527           
  Lines       24621    24621           
  Branches     3987     3987           
=======================================
  Hits        14449    14449           
  Misses       9238     9238           
  Partials      934      934

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43122e4...8b555c5. Read the comment docs.

@kimadeline kimadeline marked this pull request as ready for review November 22, 2019 17:07
@karrtikr

karrtikr commented Nov 22, 2019

Copy link
Copy Markdown

You finally ran CI on this branch👏

@kimadeline kimadeline merged commit eb0e5e9 into microsoft:master Nov 22, 2019
@kimadeline kimadeline deleted the 8727-conda-run-multi-workspace-tests branch November 22, 2019 18:00
@lock lock Bot locked as resolved and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

+1 more reviewer

@karrtikr karrtikr karrtikr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kimadeline @codecov-io @karrtikr @karthiknadig