Support pyenv and direnv#854
Conversation
|
According to the docs, Would it also be worth following shim resolution to automatically select a Python interpreter like we do for virtual environments created in the directory? |
|
Sure we can handle |
Codecov Report
@@ Coverage Diff @@
## master #854 +/- ##
==========================================
+ Coverage 63.52% 64.33% +0.81%
==========================================
Files 257 257
Lines 11850 11859 +9
Branches 2111 2112 +1
==========================================
+ Hits 7528 7630 +102
+ Misses 4314 4220 -94
- Partials 8 9 +1
Continue to review full report at Codecov.
|
DonJayamanne
left a comment
There was a problem hiding this comment.
Please use ICurrentProcess instead of process
|
It is more complicated, needs separate module installer and not pip |
|
I guess we can implement that later as an enhancement. |
|
Separated pipenv work for #404, reopening |
|
|
||
| if (!fs.pathExistsSync(targetDir)) { | ||
| fs.mkdirSync(targetDir); | ||
| fs.mkdirpSync(targetDir); |
There was a problem hiding this comment.
lol, I couldn't be bothered to identify the problem, I just created the folder with a dummy .ts file in the formatting directory.
You might want to merge master
There was a problem hiding this comment.
My solution was to ensure the directory always exists. I didn't check what code was looking for it.
Fixes #36
.direnvunder the workspaceFixes #847