Skip to content

Create a python daemon#8420

Merged
DonJayamanne merged 40 commits into
microsoft:masterfrom
DonJayamanne:daemon
Nov 8, 2019
Merged

Create a python daemon#8420
DonJayamanne merged 40 commits into
microsoft:masterfrom
DonJayamanne:daemon

Conversation

@DonJayamanne

@DonJayamanne DonJayamanne commented Nov 7, 2019 •
edited
Loading

Copy link
Copy Markdown

For #7242, #8451

@DonJayamanne
DonJayamanne requested a review from rchiodo November 7, 2019 00:52
rchiodo
rchiodo reviewed Nov 7, 2019
View reviewed changes
Comment thread pythonFiles/datascience/jupyter_daemon.py Outdated
rchiodo
rchiodo reviewed Nov 7, 2019
View reviewed changes
Comment thread src/client/datascience/jupyter/jupyterConnection.ts Outdated
rchiodo
rchiodo reviewed Nov 7, 2019
View reviewed changes
Comment thread src/client/datascience/pythonDaemon.ts
rchiodo
rchiodo previously approved these changes Nov 7, 2019
View reviewed changes

@rchiodo rchiodo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

rchiodo
rchiodo reviewed Nov 7, 2019
View reviewed changes
Comment thread pythonFiles/datascience/daemon/daemon_output.py Outdated
@codecov-io

codecov-io commented Nov 7, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8420 into master will decrease coverage by 0.06%.
The diff coverage is 25.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8420      +/-   ##
==========================================
- Coverage   59.46%   59.39%   -0.07%     
==========================================
  Files         509      509              
  Lines       23390    23423      +33     
  Branches     3779     3786       +7     
==========================================
+ Hits        13909    13913       +4     
- Misses       8575     8604      +29     
  Partials      906      906
Impacted Files Coverage Δ
src/client/datascience/jupyter/jupyterCommand.ts 95.23% <ø> (ø) ⬆️
...rc/client/datascience/jupyter/jupyterConnection.ts 70.19% <ø> (ø) ⬆️
src/client/common/process/types.ts 100% <ø> (ø) ⬆️
src/client/common/process/pythonProcess.ts 95.55% <100%> (ø) ⬆️
...rc/client/common/process/pythonExecutionFactory.ts 54.28% <14.7%> (-37.39%) ⬇️
src/client/datascience/jupyter/notebookStarter.ts 64.28% <50%> (-1.38%) ⬇️
...client/datascience/jupyter/jupyterCommandFinder.ts 75.4% <50%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa5a90...0f7d960. Read the comment docs.

@DonJayamanne DonJayamanne changed the title WIP - DS Perf Create a python daemon Nov 7, 2019
@DonJayamanne DonJayamanne added the no-changelog No news entry required label Nov 7, 2019
@rchiodo
rchiodo dismissed their stale review November 7, 2019 23:23

revoking review

rchiodo
rchiodo reviewed Nov 7, 2019
View reviewed changes
Comment thread src/client/common/process/pythonExecutionFactory.ts
rchiodo
rchiodo approved these changes Nov 7, 2019
View reviewed changes

@rchiodo rchiodo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne
DonJayamanne marked this pull request as ready for review November 8, 2019 00:03
@karthiknadig

karthiknadig commented Nov 8, 2019

Copy link
Copy Markdown
Member

Thanks for adding python-jsonrpc-server license details to toml.

@DonJayamanne DonJayamanne reopened this Nov 8, 2019
@DonJayamanne
DonJayamanne merged commit 95feda2 into microsoft:master Nov 8, 2019
@DonJayamanne
DonJayamanne deleted the daemon branch November 8, 2019 06:04
@lock lock Bot locked as resolved and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes
@rchiodo rchiodo rchiodo approved these changes

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DonJayamanne @codecov-io @karthiknadig @rchiodo