Skip to content

Improvements to startup of notebook#8332

Merged
DonJayamanne merged 6 commits into
microsoft:masterfrom
DonJayamanne:dsPerfImprovements3
Nov 5, 2019
Merged

Improvements to startup of notebook#8332
DonJayamanne merged 6 commits into
microsoft:masterfrom
DonJayamanne:dsPerfImprovements3

Conversation

@DonJayamanne

@DonJayamanne DonJayamanne commented Oct 31, 2019 •
edited
Loading

Copy link
Copy Markdown

For #7242

Parallelise various parts of starting a notebook.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Oct 31, 2019
@codecov-io

codecov-io commented Nov 1, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8332 into master will increase coverage by 0.02%.
The diff coverage is 67.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8332      +/-   ##
==========================================
+ Coverage   59.39%   59.41%   +0.02%     
==========================================
  Files         508      508              
  Lines       23236    23255      +19     
  Branches     3750     3751       +1     
==========================================
+ Hits        13800    13817      +17     
- Misses       8540     8545       +5     
+ Partials      896      893       -3
Impacted Files Coverage Δ
src/client/datascience/jupyter/notebookStarter.ts 65.65% <67.64%> (+6.31%) ⬆️
...atascience/interactive-window/interactiveWindow.ts 22.22% <0%> (-1.7%) ⬇️
src/client/terminals/codeExecution/helper.ts 21.27% <0%> (-0.73%) ⬇️
src/client/testing/navigation/symbolProvider.ts 93.1% <0%> (-0.65%) ⬇️
src/client/common/utils/localize.ts 93.99% <0%> (-0.02%) ⬇️
src/client/datascience/constants.ts 100% <0%> (ø) ⬆️
...client/datascience/jupyter/jupyterCommandFinder.ts 73.62% <0%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b202ad2...52a1c04. Read the comment docs.

rchiodo
rchiodo approved these changes Nov 1, 2019
View reviewed changes

@rchiodo rchiodo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

IanMatthewHuff
IanMatthewHuff reviewed Nov 1, 2019
View reviewed changes
Comment thread src/client/datascience/jupyter/notebookStarter.ts Outdated
IanMatthewHuff
IanMatthewHuff approved these changes Nov 1, 2019
View reviewed changes

@IanMatthewHuff IanMatthewHuff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne
DonJayamanne merged commit ef6d780 into microsoft:master Nov 5, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Nov 12, 2019
@DonJayamanne
DonJayamanne deleted the dsPerfImprovements3 branch November 15, 2019 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes
@rchiodo rchiodo rchiodo approved these changes
@DavidKutu DavidKutu Awaiting requested review from DavidKutu

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DonJayamanne @codecov-io @IanMatthewHuff @rchiodo