Fix debug temporary functional test for mac / linux#7998
Conversation
| const breakPromise = createDeferred<void>(); | ||
| disposables.push(mockDebuggerService!.onBreakpointHit(() => breakPromise.resolve())); | ||
| const done = history.debugCode(code, '\\Untitled-1', 0, docManager.activeTextEditor); | ||
| const targetUri = Uri.file(fileName); |
There was a problem hiding this comment.
In my last batch of functional fixes I only fixed this for windows :P. Gotta be careful about checking those Linux / Mac paths. I'm running a smoke build on this PR so I'll verify this fix before submitting. But it worked locally on my Mac.
| - job: 'Test' | ||
| dependsOn: [] | ||
| timeoutInMinutes: 120 | ||
| timeoutInMinutes: 180 |
There was a problem hiding this comment.
I don't want this to be a forever thing, but I really want results to look at, and these only run nightly, so I think this is ok for now. I filed this issue here in triage to look into the time this takes. Linux / Mac finish in ~30 min.
https://github.com/microsoft/vscode-python/issues/7997
Codecov Report
@@ Coverage Diff @@
## master #7998 +/- ##
==========================================
+ Coverage 58.95% 59.26% +0.31%
==========================================
Files 499 499
Lines 22413 22413
Branches 3592 3597 +5
==========================================
+ Hits 13213 13284 +71
+ Misses 8371 8300 -71
Partials 829 829
Continue to review full report at Codecov.
|
|
Per results here looks like the debug issue is resolved so submitting: |
For #7994
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)