Variable explorer and mime test fixes for tests#7740
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7740 +/- ##
==========================================
- Coverage 58.81% 58.44% -0.37%
==========================================
Files 496 496
Lines 22115 22142 +27
Branches 3558 3562 +4
==========================================
- Hits 13006 12941 -65
- Misses 8297 8383 +86
- Partials 812 818 +6
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| // If the new state includes pendingVariableCount and it's gone to zero, send a message | ||
| if ('pendingVariableCount' in newState && this.state.pendingVariableCount === 0 && oldCount !== 0) { |
Member
There was a problem hiding this comment.
this.state.pendingVariableCount === 0 && oldCount !== 0 [](start = 50, length = 55)
What's the case where we need the first part of the &&?
Author
There was a problem hiding this comment.
pendingVariableCount in newState? It indicates that we just changed it. Yeah that seems redundant now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #7369
Make variable explorer tests more deterministic
Fix a missing constant in the mime test