Skip to content

Allow connection to servers with no token and no password#7708

Merged
IanMatthewHuff merged 5 commits into
microsoft:masterfrom
IanMatthewHuff:dev/ianhu/noTokenPass
Oct 1, 2019
Merged

Allow connection to servers with no token and no password#7708
IanMatthewHuff merged 5 commits into
microsoft:masterfrom
IanMatthewHuff:dev/ianhu/noTokenPass

Conversation

@IanMatthewHuff

@IanMatthewHuff IanMatthewHuff commented Oct 1, 2019

Copy link
Copy Markdown
Member

For #7137

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

rchiodo
rchiodo approved these changes Oct 1, 2019
View reviewed changes

@rchiodo rchiodo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

DonJayamanne
DonJayamanne approved these changes Oct 1, 2019
View reviewed changes
Comment thread news/2 Fixes/7137.md
@codecov-io

codecov-io commented Oct 1, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7708 into master will decrease coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #7708      +/-   ##
=========================================
- Coverage    58.7%   58.7%   -0.01%     
=========================================
  Files         493     493              
  Lines       22011   22012       +1     
  Branches     3539    3539              
=========================================
  Hits        12922   12922              
- Misses       8280    8281       +1     
  Partials      809     809
Impacted Files Coverage Δ
src/client/datascience/types.ts 100% <ø> (ø) ⬆️
...ient/datascience/jupyter/jupyterPasswordConnect.ts 80.32% <80%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d04a4...448f5fd. Read the comment docs.

@IanMatthewHuff
IanMatthewHuff merged commit 2862614 into microsoft:master Oct 1, 2019
@IanMatthewHuff
IanMatthewHuff deleted the dev/ianhu/noTokenPass branch October 1, 2019 22:19
@lock lock Bot locked as resolved and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes
@rchiodo rchiodo rchiodo approved these changes
@DavidKutu DavidKutu Awaiting requested review from DavidKutu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IanMatthewHuff @codecov-io @DonJayamanne @rchiodo