Skip to content

Added prompt to flip "inheritEnv" setting to false to fix conda activation issue#7633

Merged
karrtikr merged 7 commits into
microsoft:masterfrom
karrtikr:inheritenv
Oct 2, 2019
Merged

Added prompt to flip "inheritEnv" setting to false to fix conda activation issue#7633
karrtikr merged 7 commits into
microsoft:masterfrom
karrtikr:inheritenv

Conversation

@karrtikr
Copy link
Copy Markdown

@karrtikr karrtikr commented Sep 27, 2019 •
edited
Loading

For #7607

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@karrtikr karrtikr changed the title Added prompt to flip "inheritEnv" setting to false to fix conda activation issue WIP - Added prompt to flip "inheritEnv" setting to false to fix conda activation issue Sep 27, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 27, 2019 •
edited
Loading

Codecov Report

Merging #7633 into master will increase coverage by 0.09%.
The diff coverage is 98.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7633      +/-   ##
==========================================
+ Coverage   58.72%   58.81%   +0.09%     
==========================================
  Files         494      495       +1     
  Lines       22027    22081      +54     
  Branches     3541     3552      +11     
==========================================
+ Hits        12935    12988      +53     
  Misses       8281     8281              
- Partials      811      812       +1
Impacted Files Coverage Δ
src/client/telemetry/index.ts 86.13% <ø> (ø) ⬆️
src/client/interpreter/serviceRegistry.ts 100% <100%> (ø) ⬆️
src/client/telemetry/constants.ts 100% <100%> (ø) ⬆️
src/client/common/utils/localize.ts 93.93% <100%> (+0.01%) ⬆️
...t/interpreter/virtualEnvs/condaInheritEnvPrompt.ts 98% <98%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2862614...d39e2c4. Read the comment docs.

@karrtikr karrtikr changed the title WIP - Added prompt to flip "inheritEnv" setting to false to fix conda activation issue Added prompt to flip "inheritEnv" setting to false to fix conda activation issue Sep 30, 2019
karthiknadig
karthiknadig reviewed Oct 1, 2019
View reviewed changes
Comment thread src/client/interpreter/virtualEnvs/condaInheritEnvPrompt.ts
DonJayamanne
DonJayamanne requested changes Oct 1, 2019
View reviewed changes
Copy link
Copy Markdown

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Activate should be non blocking.

@karthiknadig karthiknadig mentioned this pull request Oct 1, 2019
Closed
@karrtikr karrtikr closed this Oct 1, 2019
@karrtikr karrtikr reopened this Oct 1, 2019
@karrtikr karrtikr closed this Oct 1, 2019
@karrtikr karrtikr reopened this Oct 1, 2019
@ericsnowcurrently ericsnowcurrently removed their request for review October 1, 2019 18:37
@karrtikr
Copy link
Copy Markdown
Author

karrtikr commented Oct 1, 2019 •
edited
Loading

Smoke UITest Linuxstable27Smoke times out😞 Maybe we should've these under CI pipeline instead of PR validation @DonJayamanne ?

@karrtikr karrtikr closed this Oct 1, 2019
@karrtikr karrtikr reopened this Oct 1, 2019
@karrtikr karrtikr merged commit e4e2fd2 into microsoft:master Oct 2, 2019
@karrtikr karrtikr deleted the inheritenv branch October 2, 2019 08:35
@lock lock Bot locked as resolved and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@karthiknadig karthiknadig karthiknadig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@karrtikr @codecov-io @DonJayamanne @karthiknadig