Skip to content

Update timeout value for CI builds#7577

Merged
rchiodo merged 1 commit into
masterfrom
rchiodo-patch-1
Sep 24, 2019
Merged

Update timeout value for CI builds#7577
rchiodo merged 1 commit into
masterfrom
rchiodo-patch-1

Conversation

@rchiodo

@rchiodo rchiodo commented Sep 24, 2019

Copy link
Copy Markdown

CI builds are sometimes timing out. Up the timeout value.

@rchiodo rchiodo self-assigned this Sep 24, 2019
@rchiodo rchiodo added the no-changelog No news entry required label Sep 24, 2019
jobs:
- job: 'Test'
dependsOn: []
timeoutInMinutes: 120

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, what was the default here without this specified?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't it 60?

image

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's 60. Looks like some of the test are close to 60.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimadeline kimadeline left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to up the timeout for the nightly runs as well?

@IanMatthewHuff IanMatthewHuff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo

rchiodo commented Sep 24, 2019

Copy link
Copy Markdown
Author

Yeah probably. I'll do that too.

@rchiodo

rchiodo commented Sep 24, 2019

Copy link
Copy Markdown
Author

Oh actually the nightly is already set to 120 minutes

@codecov-io

codecov-io commented Sep 24, 2019

Copy link
Copy Markdown

Codecov Report

Merging #7577 into master will decrease coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7577      +/-   ##
==========================================
- Coverage    58.9%   58.22%   -0.69%     
==========================================
  Files         492      492              
  Lines       21863    21513     -350     
  Branches     3507     3502       -5     
==========================================
- Hits        12878    12525     -353     
- Misses       8183     8186       +3     
  Partials      802      802
Impacted Files Coverage Δ
...nt/datascience/jupyter/invalidNotebookFileError.ts 0% <0%> (-75%) ⬇️
.../client/datascience/jupyter/jupyterConnectError.ts 0% <0%> (-66.67%) ⬇️
...science/jupyter/jupyterKernelPromiseFailedError.ts 0% <0%> (-50%) ⬇️
...ent/datascience/jupyter/jupyterWaitForIdleError.ts 0% <0%> (-50%) ⬇️
src/client/api.ts 60% <0%> (-27.5%) ⬇️
src/client/language/characters.ts 12% <0%> (-21.34%) ⬇️
src/client/testing/codeLenses/main.ts 60% <0%> (-17.78%) ⬇️
src/client/datascience/cellFactory.ts 72.34% <0%> (-17.32%) ⬇️
src/client/constants.ts 75% <0%> (-5%) ⬇️
src/client/providers/providerUtilities.ts 84.61% <0%> (-4.28%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdbd61a...0b109be. Read the comment docs.

@rchiodo rchiodo merged commit 9b3edc2 into master Sep 24, 2019
@rchiodo rchiodo deleted the rchiodo-patch-1 branch September 24, 2019 17:02
@lock lock Bot locked as resolved and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants