Skip to content

Add bug and feature templates for Data Science features - #7545

Merged
Jim Griesmer (greazer) merged 3 commits into
masterfrom
jimgries/dsissues
Sep 23, 2019
Merged

Add bug and feature templates for Data Science features#7545
Jim Griesmer (greazer) merged 3 commits into
masterfrom
jimgries/dsissues

Conversation

@greazer

Copy link
Copy Markdown

No description provided.

@greazer Jim Griesmer (greazer) added the no-changelog No news entry required label Sep 23, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to capture the version of jupyter?
Or do we not have any/many issues to warrant requesting this info?

@codecov-io

Codecov (codecov-io) commented Sep 23, 2019

Copy link
Copy Markdown

Codecov Report

Merging #7545 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7545      +/-   ##
==========================================
+ Coverage   58.85%   58.89%   +0.04%     
==========================================
  Files         492      492              
  Lines       21823    21853      +30     
  Branches     3501     3504       +3     
==========================================
+ Hits        12843    12870      +27     
- Misses       8179     8181       +2     
- Partials      801      802       +1
Impacted Files Coverage Δ
src/client/debugger/extension/adapter/factory.ts 94.28% <0%> (-2.86%) ⬇️
...on/terminal/environmentActivationProviders/bash.ts 88.88% <0%> (-1.12%) ⬇️
src/client/debugger/extension/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/api.ts 87.5% <0%> (ø) ⬆️
src/client/debugger/extension/types.ts 100% <0%> (ø) ⬆️
src/client/datascience/types.ts 100% <0%> (ø) ⬆️
src/client/common/utils/localize.ts 93.88% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dec031...c0afda2. Read the comment docs.

@greazer

Copy link
Copy Markdown
Author

Do we need to capture the version of jupyter?
Or do we not have any/many issues to warrant requesting this info?

No, we don't see many bugs related to the jupyter version. If we need it, we'll ask.

Comment thread .github/ISSUE_TEMPLATE/ds_bug_report.md Outdated
@@ -0,0 +1,44 @@
---
name: Jupyter Notebook, Interactive Window, or code-cell Bug

@IanMatthewHuff Ian Huff (IanMatthewHuff) Sep 23, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jupyter Notebook [](start = 6, length = 16)

In our settings we currently always call the new feature the "Notebook Editor." Seems like we should have the official feature name listed in the template.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also a bit unsure on the "code-cell" naming particularly with the hyphen, which we don't use in our settings for changing code cells.

My suggestion would be:
[Jupyter] Notebook Editor, Interactive Window, .py file Notebook cells


In reply to: 327335646 [](ancestors = 327335646)

@IanMatthewHuff Ian Huff (IanMatthewHuff) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@greazer
Jim Griesmer (greazer) merged commit bedaf9b into master Sep 23, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Sep 30, 2019
@kimadeline
Kim-Adeline Miguel (kimadeline) deleted the jimgries/dsissues branch November 28, 2019 23:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants