Skip to content

Native left side nav bar#7438

Merged
IanMatthewHuff merged 2 commits into
microsoft:masterfrom
IanMatthewHuff:dev/ianhu/nativeCellNavbar
Sep 17, 2019
Merged

Native left side nav bar#7438
IanMatthewHuff merged 2 commits into
microsoft:masterfrom
IanMatthewHuff:dev/ianhu/nativeCellNavbar

Conversation

@IanMatthewHuff
Copy link
Copy Markdown
Member

@IanMatthewHuff IanMatthewHuff commented Sep 17, 2019

For #7377

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

rchiodo
rchiodo previously approved these changes Sep 17, 2019
View reviewed changes
Copy link
Copy Markdown

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 17, 2019 •
edited
Loading

Codecov Report

Merging #7438 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #7438      +/-   ##
=========================================
- Coverage   58.54%   58.5%   -0.04%     
=========================================
  Files         492     492              
  Lines       21747   21747              
  Branches     3486    3486              
=========================================
- Hits        12731   12724       -7     
- Misses       8229    8241      +12     
+ Partials      787     782       -5
Impacted Files Coverage Δ
src/client/common/logger.ts 68.55% <0%> (-4.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cacf988...437947a. Read the comment docs.

@rchiodo rchiodo dismissed their stale review September 17, 2019 17:12

revoking review

rchiodo
rchiodo approved these changes Sep 17, 2019
View reviewed changes
Copy link
Copy Markdown

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@IanMatthewHuff IanMatthewHuff merged commit d355d28 into microsoft:master Sep 17, 2019
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/nativeCellNavbar branch September 17, 2019 17:55
@lock lock Bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rchiodo rchiodo rchiodo approved these changes

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IanMatthewHuff @codecov-io @rchiodo