Skip to content

Choose kernel and reconnect to running kernel#7191

Closed
hochshi wants to merge 13 commits into
microsoft:masterfrom
hochshi:master
Closed

Choose kernel and reconnect to running kernel#7191
hochshi wants to merge 13 commits into
microsoft:masterfrom
hochshi:master

Conversation

@hochshi
Copy link
Copy Markdown

@hochshi hochshi commented Sep 4, 2019

For #7014 , #3763

Fixes the requested changes on #7015 and adds the ability the select the remote kernel to connect to. This was done together since the kernel uuid is passed down using IJupyterKernelSpec instead of setting a different setting just for the kernel UUID.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • ~Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@msftclas
Copy link
Copy Markdown

msftclas commented Sep 4, 2019

CLA assistant check
All CLA requirements met.

@hochshi
Copy link
Copy Markdown
Author

hochshi commented Oct 3, 2019

Hi @rchiodo,

Any news on this? I'm willing to put in extra work to make this happen quicker.
The rest of my team could really use these enhancements and I'd rather do it through the appropriate procedure.

Thanks

@rchiodo
Copy link
Copy Markdown

rchiodo commented Oct 3, 2019

Wasn't sure if you were continuing to work on this or not? Unfortunately we aren't going to take it up anytime soon as we're all heads down on supporting notebooks at the moment.

In order to submit this you might have to refactor some stuff as we've changed quite a bit for notebook support.

If you want to try updating, we're happy to review it again. I think we were all okay with the extra setting for picking the remote kernel.

@hochshi
Copy link
Copy Markdown
Author

hochshi commented Oct 4, 2019

Great.
I'll get to it :)

@hochshi
Copy link
Copy Markdown
Author

hochshi commented Oct 7, 2019

It was easier to re-implement than play around with trying to merge the changes.
Same features are available at #7790 .

@hochshi hochshi closed this Oct 7, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants