Skip to content

Support "pathMappings" in "launch" debug configs.#7024

Merged
ericsnowcurrently merged 22 commits into
microsoft:masterfrom
ericsnowcurrently:fix-3568-launch-pathmappings
Aug 26, 2019
Merged

Support "pathMappings" in "launch" debug configs.#7024
ericsnowcurrently merged 22 commits into
microsoft:masterfrom
ericsnowcurrently:fix-3568-launch-pathmappings

Conversation

@ericsnowcurrently
Copy link
Copy Markdown

@ericsnowcurrently ericsnowcurrently commented Aug 19, 2019 •
edited
Loading

(for #3568)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@kimadeline kimadeline self-requested a review August 20, 2019 17:40
kimadeline
kimadeline approved these changes Aug 20, 2019
View reviewed changes
Comment thread src/client/debugger/types.ts
Comment thread src/test/debugger/extension/configuration/resolvers/attach.unit.test.ts Outdated
Comment thread src/test/debugger/extension/configuration/resolvers/launch.unit.test.ts
Comment thread src/test/debugger/extension/configuration/resolvers/launch.unit.test.ts
Comment thread src/test/debugger/extension/configuration/resolvers/launch.unit.test.ts
Comment thread src/test/debugger/extension/configuration/resolvers/launch.unit.test.ts
Comment thread src/test/debugger/extension/configuration/resolvers/launch.unit.test.ts Outdated
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 21, 2019 •
edited
Loading

Codecov Report

Merging #7024 into master will increase coverage by 0.08%.
The diff coverage is 86.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7024      +/-   ##
==========================================
+ Coverage   58.29%   58.38%   +0.08%     
==========================================
  Files         483      483              
  Lines       21347    21421      +74     
  Branches     3445     3474      +29     
==========================================
+ Hits        12445    12507      +62     
- Misses       8124     8141      +17     
+ Partials      778      773       -5
Impacted Files Coverage Δ
src/client/debugger/types.ts 100% <ø> (ø) ⬆️
...bugger/extension/configuration/resolvers/attach.ts 79.24% <100%> (-3.3%) ⬇️
src/client/common/platform/platformService.ts 33.33% <33.33%> (-9.17%) ⬇️
src/client/common/utils/platform.ts 88.23% <75%> (-11.77%) ⬇️
...bugger/extension/configuration/resolvers/launch.ts 88.09% <77.77%> (-1.52%) ⬇️
...debugger/extension/configuration/resolvers/base.ts 96.77% <94.73%> (-1.01%) ⬇️
src/client/common/logger.ts 68.55% <0%> (-4.41%) ⬇️
src/client/linters/baseLinter.ts 80.34% <0%> (-1.37%) ⬇️
...atascience/interactive-window/interactiveWindow.ts 7.38% <0%> (-0.04%) ⬇️
src/client/common/configSettings.ts 57.54% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b626b...241316a. Read the comment docs.

karrtikr
karrtikr suggested changes Aug 21, 2019
View reviewed changes
Copy link
Copy Markdown

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to understand the test code before merging it. Things seem a bit magical.

Comment thread src/test/debugger/extension/configuration/resolvers/launch.unit.test.ts Outdated
karrtikr
karrtikr reviewed Aug 21, 2019
View reviewed changes
Comment thread src/test/debugger/extension/configuration/resolvers/common.ts Outdated
karrtikr
karrtikr reviewed Aug 21, 2019
View reviewed changes
Comment thread src/test/debugger/extension/configuration/resolvers/common.ts Outdated
@ericsnowcurrently
Copy link
Copy Markdown
Author

ericsnowcurrently commented Aug 22, 2019

As far as I can tell, the current CI failures here are unrelated to this PR.

@karrtikr
Copy link
Copy Markdown

karrtikr commented Aug 23, 2019

@ericsnowcurrently You will have to rebase from master branch.

@ericsnowcurrently ericsnowcurrently merged commit a0094d4 into microsoft:master Aug 26, 2019
@ericsnowcurrently ericsnowcurrently deleted the fix-3568-launch-pathmappings branch August 26, 2019 20:42
@ericsnowcurrently ericsnowcurrently mentioned this pull request Aug 27, 2019
Closed
@lock lock Bot locked as resolved and limited conversation to collaborators Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@karrtikr karrtikr karrtikr approved these changes

@kimadeline kimadeline kimadeline approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ericsnowcurrently @codecov-io @karrtikr @kimadeline