Support debugging newly imported files#6776
Merged
Merged
Conversation
| public async debugCode(code: string, file: string, line: number, editor?: TextEditor): Promise<boolean> { | ||
| let saved = true; | ||
| // Make sure the file is saved before debugging | ||
| const doc = this.documentManager.textDocuments.find(d => d.fileName === file); |
Member
There was a problem hiding this comment.
I usually use IFileSystem.arePathsSame for these types of comparisons. Probably not an issue, but I think that it's a bit safer.
Author
There was a problem hiding this comment.
I think I want case sensitive on Windows even.
| // the new entry in the list | ||
| if (saved) { | ||
| const afterSave = [...this.documentManager.textDocuments]; | ||
| const diff = afterSave.filter(f => beforeSave.indexOf(f) === -1); |
Member
There was a problem hiding this comment.
Filter creates a new array so you shouldn't need the spread operator copy above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #6738
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)