Data Explorer Accessiblity#6704
Conversation
|
Sorry phantom commits are back for some reason |
| } | ||
| }, | ||
| "@types/jquery": { | ||
| "version": "3.3.29", |
There was a problem hiding this comment.
29 [](start = 22, length = 2)
This seems odd? Why did it go backwards? #ByDesign
There was a problem hiding this comment.
Ah, we didn't used to install it. Maybe it should be the newer version?
In reply to: 307522512 [](ancestors = 307522512)
There was a problem hiding this comment.
So what I did here was that the types were missing from the slick grid reference. So I added in the closest version to the version that slick grid was using 1.11.2 that's the version in slickgrid and the version that I use manually in reactSlickGrid.tsx. But I'm not sure that actually matters here, I think the newer ones would work as well?
In reply to: 307522767 [](ancestors = 307522767,307522512)
There was a problem hiding this comment.
Maybe not. They may not line up. Not sure how we make the person editing slickgrid realize this.
In reply to: 307525920 [](ancestors = 307525920,307522767,307522512)
There was a problem hiding this comment.
I'm not fully sure about this, so I can change if you think that I'm off. But I think that sticking with the type for the version of jquery that we are actually using (I think this is the only place we are actually using it in the extension) would be the right call for now at least.
In reply to: 307526879 [](ancestors = 307526879,307525920,307522767,307522512)
| // Don't let the parent / browser do stuff if we handle it | ||
| // otherwise we'll both move the cell selection and scroll the window | ||
| // with up and down keys | ||
| e.stopPropagation(); |
There was a problem hiding this comment.
stopPropagation [](start = 14, length = 15)
Does NVDA (or whatever the screen reader was called) still work? Thought you said this was messing it up? Or is it only if it swallows tab? #ByDesign
There was a problem hiding this comment.
Yeah, seemed ok to me. I wasn't getting the issues. I believe that it was StopImmediatePropagation that causes the issues. StopPropagation stops propagation for the current event. StopImmediatePropatagation prevents other listeners of the same event from being called.
In reply to: 307523176 [](ancestors = 307523176)
| // The slickgrid version of jquery populates keyCode not code, so use the numerical values here | ||
| switch (e.keyCode) { | ||
| // LeftArrow | ||
| case 37: |
There was a problem hiding this comment.
37 [](start = 21, length = 2)
I believe there's a constant for this somewhere.
Oh it's in the monacoEditor namespace. Might be a little weird to reference it here. #Resolved
There was a problem hiding this comment.
I don't want to use the monaco one, but even though I don't see reusing this much (we only use the keyCodes here since this jquery version doesn't populate code) this probably would look cleaner with a constant. I'll add one in like react-common or someplace like that.
In reply to: 307523433 [](ancestors = 307523433)
For #6019
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)