Make input box more visible.#6605
Merged
Merged
Conversation
Author
|
This is what it looks like after the change
|
rchiodo
commented
Jul 16, 2019
| border-top-width: 1px; | ||
| } No newline at end of file | ||
| border-top-width: 2px; | ||
| background-color: var(--override-peek-background, var(--vscode-peekViewEditor-background)); |
Author
There was a problem hiding this comment.
override [](start = 28, length = 8)
Actually this needs to be updated. It won't turn off if the user sets the setting to false
#Resolved
| private renderInputs = () => { | ||
| if (this.showInputs()) { | ||
| const backgroundColor = this.props.cellVM.cell.type === 'preview' ? | ||
| const backgroundColor = this.props.cellVM.cell.type === 'preview' || (getSettings().colorizeInputBox && this.props.cellVM.editable) ? |
Member
There was a problem hiding this comment.
I suppose this might cause issues when you do your work to make more cells editable (editable will no longer be equal to input box) but we can just deal with this at that time.
Author
There was a problem hiding this comment.
Yeah I think we'll get rid of the preview state at that point.
In reply to: 304099600 [](ancestors = 304099600)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #6381
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)