Renamed pep8 to pycodestyle#6570
Conversation
|
|
|
It seems all the tests passed. Something must have been configured wrong on my end. |
DonJayamanne
left a comment
There was a problem hiding this comment.
Thanks for the PR, awesome work.
A few changes:
- Please do not deprecate the old setting (just remove it).
- We'll need to migrate existing users from the old setting to the new (see https://github.com/microsoft/vscode-python/blob/master/src/client/testing/common/updateTestSettings.ts, we've done this in the past).
|
@DonJayamanne I do not have any experience with typescript, but I'll see what I can do. Should I be adding these new checks to the same file, or creating a new one? |
|
Just pushed a new commit. I added into the same file support for renaming the settings. |
…nto pep8-rename
That's fine, we can do that work. Thank for your awesome work. |
|
@DonJayamanne @ericsnowcurrently I have not heard anything about this in a while. Anything I need to do? |
Codecov Report
@@ Coverage Diff @@
## master #6570 +/- ##
==========================================
- Coverage 58.48% 58.44% -0.04%
==========================================
Files 485 485
Lines 21437 21446 +9
Branches 3462 3462
==========================================
- Hits 12537 12535 -2
- Misses 8122 8135 +13
+ Partials 778 776 -2
Continue to review full report at Codecov.
|
For #410
Not 100% sure if this passes CI checks (my computer was a bit finicky with unit tests), but I am setting up the PR now to trigger the CI system and see if everything looks good.
Has sufficient logging.Has telemetry for enhancements.Test plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)The wiki is updated with any design decisions/details.