Remove existing positional args when running a single test on pytest#6537
Merged
Conversation
added 4 commits
July 11, 2019 08:12
DonJayamanne
approved these changes
Jul 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #5757
Positional arguments are not always the last ones in the args list: in the repro case in #5757 (comment) the arg list is
[ "tests", "-sv"]. This PR makes the parsing of positional args more flexible: instead of slicing the args array and keeping everything after the last option, we filter out non-positional args.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)