Release 2019.6.0-rc#6245
Merged
ericsnowcurrently merged 16 commits intoJun 20, 2019
Merged
Conversation
Author
|
Feel free to merge this (if it looks okay) if you review this before I start my day tomorrow. :) |
10 tasks
DonJayamanne
approved these changes
Jun 20, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #5825)
In particular, I want to make sure that
tpn/distribution.toml, andThirdPartyNotices-Distribution.txtlook okay.Has a news entry file (remember to thank yourself!)Appropriate comments and documentation strings in the codeHas sufficient logging.Has telemetry for enhancements.Unit tests & system/integration tests are added/updatedTest plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)The wiki is updated with any design decisions/details.