Skip to content

Print stdout/stderr when pytest fails (in adapter script).#5512

Merged
ericsnowcurrently merged 8 commits into
microsoft:masterfrom
ericsnowcurrently:pytest-discovery-failure
Apr 29, 2019
Merged

Print stdout/stderr when pytest fails (in adapter script).#5512
ericsnowcurrently merged 8 commits into
microsoft:masterfrom
ericsnowcurrently:pytest-discovery-failure

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Apr 29, 2019

Copy link
Copy Markdown

(for #5313)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@DonJayamanne DonJayamanne left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but don't we need any tests for this?

Comment thread src/client/testing/common/services/discovery.ts Outdated
@ericsnowcurrently
ericsnowcurrently merged commit 77a510c into microsoft:master Apr 29, 2019
@ericsnowcurrently
ericsnowcurrently deleted the pytest-discovery-failure branch April 29, 2019 22:50
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants