Skip to content

Allows test discovery when flake8-plugin to pytest is set to run #5491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdavezac wants to merge 3 commits into from
Closed

Allows test discovery when flake8-plugin to pytest is set to run #5491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16fd693
allow pyflake pluggin to work
mdavezac Apr 26, 2019
fdb2aa7
Adds news for PR 5491
mdavezac Apr 26, 2019
2889a5b
Update news/2 Fixes/5491.md
brettcannon Apr 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/2 Fixes/5491.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix pytest tests discovery for when flake8 pytest plugin is enabled.
(thanks [Mayeul d'Avezac](https://github.com/mdavezac))
4 changes: 2 additions & 2 deletions pythonFiles/testing_tools/adapter/pytest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def _parse_item(item, _normcase, _pathsep):
testfunc = '.'.join(suites) + '.' + funcname
else:
testfunc = funcname
elif kind == 'doctest':
else:
testfunc = None
funcname = None

Expand Down Expand Up @@ -397,7 +397,7 @@ def _get_item_kind(item):
return 'function', False
elif itemtype == 'TestCaseFunction':
return 'function', True
elif item.hasattr('function'):
elif hasattr(item, 'function'):
return 'function', False
else:
return None, False
Expand Down