Fix Variable Explorer functional tests in python 2.7 3.5#5465
Merged
IanMatthewHuff merged 1 commit intoApr 25, 2019
Merged
Conversation
IanMatthewHuff
commented
Apr 25, 2019
| const basicCode: string = `import numpy as np | ||
| import pandas as pd | ||
| myList = [x ** 2 for x in range(0,100000)] | ||
| const basicCode: string = `myList = [1, 2, 3] |
Member
Author
There was a problem hiding this comment.
Just simplified everything. Dict had the same issue as set, that I forgot to fix when I fixed set. In python 2.7 the list comprehension leaked out the x value so the var exp picked it up and had an extra item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #5433
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)