Skip to content

Add telemetry for debugger - #546

Merged
Don Jayamanne (DonJayamanne) merged 58 commits into
microsoft:masterfrom
DonJayamanne:AddTelemetryForDebugger
Jan 23, 2018
Merged

Add telemetry for debugger#546
Don Jayamanne (DonJayamanne) merged 58 commits into
microsoft:masterfrom
DonJayamanne:AddTelemetryForDebugger

Conversation

@DonJayamanne

Copy link
Copy Markdown

Pine (octref) and others added 30 commits November 3, 2017 13:11
* 'master' of https://github.com/Microsoft/vscode-python:
  Fixes #56 list all environments (#219)
  Fixes #57 Disable activation on debugging (#220)
  Fixes #26 Do not run linters when linters are disabled (#222)
* upstream/master:
  Fix typo in README.md (#252)
  Disable linter without workspaces (#241)
* upstream/master:
  Fix feedback service (#246)
  Fix django context initializer (#248)
  disable generation of tags file upon extension load (#264)
* upstream/master:
  Resolve pythonPath before comparing it to shebang (#273)
* upstream/master:
  Fixes #22 to Detect anaconda from known locations  (#221)
  Use workspaceFolder token instead of workspaceRoot (#267)
  Fix registry lookup response (#224)
  Fix issues when running without debugging and debugged code terminates (#249)
* upstream/master:
  Fix debugging tests (#304)
* upstream/master:
  Remove jupyter functionality in favor of Jupyter extension (#302)
  Drop Python 2 URLs (#307)
* upstream/master:
  Remove setting python.formatting.formatOnSave in favor of the vs code setting (#312)
* upstream/master:
  Remove setting linting.lintOnTextChange as it was never implemented (#315)
* upstream/master:
  Fix travis build error (#326)
* upstream/master:
  add new npm deps with improved gulp for dev (#328)
* upstream/master:
  Update version of inversify package (#329)
* upstream/master:
  Document our dev process (#330)
* upstream/master:
  Document contribution to the code along with coding standards (#321)
* upstream/master:
  Add Simplified Chinese translation of commands (#240)
* upstream/master:
  Fix package.json (#347)
* upstream/master:
  #34, #110 - suppress Intellisense in strings and comments (#339)
  Re-factor code python execution framework  (#345)
* upstream/master:
  Fix linters to make use of the new python code execution framework (#360)
  Update the versioning scheme (#356)
  Make npm happy in regards to line endings (#357)
* upstream/master:
  Ensure python path is not set if already set in user settings (#369)
  Use 'an' rather than 'a' before vowel words (#373)
* upstream/master:
  Use new environment variable parser (#362)
* upstream/master:
  Refactor formatters to use new execution framework (#426)
* upstream/master:
  Release 0.9.1 (#458)
  Add localization for Japanese (#434)
  Add Svn to uriSchemesToIgnore (#443)
* upstream/master:
  Refactor parsing of environment variables (after 439) (#466)
  Refactor extension to remove old way of spawning python processes (#439)
* upstream/master:
  Common execution for python tool or module (#468)
* upstream/master:
  Complete refactoring of code to use new code exec engine (#493)
* upstream/master:
  Improve interpreter selection on different platforms (#517)
  Yarn and code coverage (#475)
* upstream/master:
  Remove Homebrew installation  (#537)
  Introduce per user installation of modules and elevated global install as an option (#532)
  Fix spawn args (#489)
@DonJayamanne

Copy link
Copy Markdown
Author

WIP - waiting to get final requirements from Dan Taylor (@qubitron)

@codecov

codecov Bot commented Jan 9, 2018

Copy link
Copy Markdown

Codecov Report

Merging #546 into master will increase coverage by 0.06%.
The diff coverage is 18.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
+ Coverage   58.06%   58.13%   +0.06%     
==========================================
  Files         225      211      -14     
  Lines       10152     9798     -354     
  Branches     1751     1730      -21     
==========================================
- Hits         5895     5696     -199     
+ Misses       4252     4097     -155     
  Partials        5        5
Impacted Files Coverage Δ
src/client/debugger/DebugClients/DebugFactory.ts 0% <ø> (ø) ⬆️
src/client/debugger/Common/Utils.ts 22.95% <ø> (ø) ⬆️
src/client/debugger/index.ts 100% <ø> (ø) ⬆️
src/client/debugger/ProxyCommands.ts 0% <ø> (ø) ⬆️
...rc/client/debugger/DebugServers/BaseDebugServer.ts 0% <0%> (ø) ⬆️
src/client/debugger/PythonProcess.ts 0% <0%> (ø) ⬆️
src/client/debugger/DebugClients/DebugClient.ts 0% <0%> (ø) ⬆️
src/client/debugger/Common/TryParser.ts 0% <0%> (ø) ⬆️
.../client/debugger/DebugClients/RemoteDebugClient.ts 0% <0%> (ø) ⬆️
...rc/client/debugger/PythonProcessCallbackHandler.ts 0% <0%> (ø) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba069d2...ee46e1e. Read the comment docs.

@DonJayamanne Don Jayamanne (DonJayamanne) changed the title WIP - Add telemetry for debugger Add telemetry for debugger Jan 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming you have seen actual telemetry data for this show up in vscodetel. 😉

let column = line.indexOf("except");

// Do we have a try block for this same column
// Do we have a try block for this same column

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a period.

@DonJayamanne

Don Jayamanne (DonJayamanne) commented Jan 17, 2018

Copy link
Copy Markdown
Author

Brett Cannon (@brettcannon) Mikhail Arkhipov (@MikhailArkhipov)
I'm not having luck in getting the telemetry working.
Please could one of you try the following:

  • Install our latest (production) extension
  • Open the following file in the extension (out/client/debugger/Main.js)
  • Edit line 214 and change the value of trigger from launch to abc
  • Debug a simple python file using VS Code (please debug a file at least twice, so we know we have something sent for certain)

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit df2b494 into microsoft:master Jan 23, 2018
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the AddTelemetryForDebugger branch January 25, 2018 19:33
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add telemetry to measure performance of debugger

3 participants