Skip to content

Ensure prompt is displayed to install pylint when user has configured pylint#5356

Merged
karrtikr merged 2 commits into
microsoft:masterfrom
karrtikr:pylintbug
Apr 18, 2019
Merged

Ensure prompt is displayed to install pylint when user has configured pylint#5356
karrtikr merged 2 commits into
microsoft:masterfrom
karrtikr:pylintbug

Conversation

@karrtikr

@karrtikr karrtikr commented Apr 18, 2019

Copy link
Copy Markdown

For #5087

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@DonJayamanne DonJayamanne left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very simple and readable.

Comment thread src/test/linters/linterinfo.unit.test.ts
@karrtikr karrtikr merged commit b9a86b0 into microsoft:master Apr 18, 2019
@karrtikr karrtikr deleted the pylintbug branch April 18, 2019 06:23
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants