correctly show variables after jupyter restart - #5336
Merged
Ian Huff (IanMatthewHuff) merged 1 commit intoApr 17, 2019
Merged
Conversation
| vars.forEach((value: IJupyterVariable) => { | ||
| value.executionCount = executionCount; | ||
| variablesResponse.variables.forEach((value: IJupyterVariable) => { | ||
| value.executionCount = requestExecutionCount; |
Member
Author
There was a problem hiding this comment.
Technically the variables don't need this count anymore. But I was leaving it in as it seemed like it could be useful in the future. Like if we pass off an IJupyterVariable to something like the data explorer we could know what execution count was associated with it. Could also remove it if that doesn't seem like a good reason.
There was a problem hiding this comment.
You're still checking this in the mainpanel. Why are you saying you don't need it anymore?
In reply to: 276410195 [](ancestors = 276410195)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #5244
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)