Use a document selector pattern only in multi-root#5334
Merged
Conversation
ericsnowcurrently
approved these changes
Apr 17, 2019
ericsnowcurrently
left a comment
There was a problem hiding this comment.
Aside from a couple of minor comments, LGTM.
Also, just be be sure I understood the PR, the only real change is on line 151, right? Everything else is just factoring out the private getDocumentSelector() method (which I approve, BTW :) ).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #5333
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)