Skip to content

Accomadate trailing commas in parsed launch.json#5331

Merged
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:issue4543
Apr 17, 2019
Merged

Accomadate trailing commas in parsed launch.json#5331
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:issue4543

Conversation

@DonJayamanne
Copy link
Copy Markdown

@DonJayamanne DonJayamanne commented Apr 17, 2019

For #4543

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

ericsnowcurrently
ericsnowcurrently approved these changes Apr 17, 2019
View reviewed changes
Copy link
Copy Markdown

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DonJayamanne DonJayamanne merged commit 1799d75 into microsoft:master Apr 17, 2019
@DonJayamanne DonJayamanne deleted the issue4543 branch May 24, 2019 20:20
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DonJayamanne @ericsnowcurrently