Skip to content

Dev/ianhu/variable functional tests#5300

Merged
IanMatthewHuff merged 5 commits into
microsoft:masterfrom
IanMatthewHuff:dev/ianhu/variableFunctionalTests
Apr 16, 2019
Merged

Dev/ianhu/variable functional tests#5300
IanMatthewHuff merged 5 commits into
microsoft:masterfrom
IanMatthewHuff:dev/ianhu/variableFunctionalTests

Conversation

@IanMatthewHuff

@IanMatthewHuff IanMatthewHuff commented Apr 16, 2019

Copy link
Copy Markdown
Member

For #4803

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff IanMatthewHuff requested a review from rchiodo April 16, 2019 17:17
rchiodo
rchiodo approved these changes Apr 16, 2019
View reviewed changes

@rchiodo rchiodo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@IanMatthewHuff IanMatthewHuff merged commit 83b9821 into microsoft:master Apr 16, 2019
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/variableFunctionalTests branch July 25, 2019 23:52
@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rchiodo rchiodo rchiodo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IanMatthewHuff @rchiodo