Simplify import telemetry#5246
Merged
Merged
Conversation
We only care about the top-level package, so scale back what we are sending in telemetry. We also want to avoid hashing, so store locally the unhashed names for comparison instead of the hashes.
rchiodo
reviewed
Apr 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #4852 , #4718
We only care about top-level packages, so we can simplify the code a bit and rely on Python's own syntax a bit more. We also only care about imports in opened or saved files, and so we can drop caring about anything else. Lastly, check whether we have sent the import already based on its unhashed name to avoid the CPU cost of the hash to begin with.