Skip to content

New command to run all of file regardless of cells - #4893

Merged
Ian Huff (IanMatthewHuff) merged 4 commits into
microsoft:masterfrom
IanMatthewHuff:dev/ianhu/runFileInteractiveFixes
Mar 22, 2019
Merged

New command to run all of file regardless of cells#4893
Ian Huff (IanMatthewHuff) merged 4 commits into
microsoft:masterfrom
IanMatthewHuff:dev/ianhu/runFileInteractiveFixes

Conversation

@IanMatthewHuff

Copy link
Copy Markdown
Member

For #4855

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

Comment thread package.json
},
{
"command": "python.datascience.runallcells",
"title": "%python.command.python.datascience.runallcells.command.title%",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note if this looks a bit funny. The "Run All Cells" command had both a code lens command and a command palette command. My change removed the string that was no longer used by the code lens so we removed the .command. version of the string. Now the code lens "Run All Cells" shows up in the context menu and command palette.

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov

codecov Bot commented Mar 22, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4893 into master will increase coverage by 1%.
The diff coverage is 89%.

@@          Coverage Diff           @@
##           master   #4893   +/-   ##
======================================
+ Coverage      63%     63%   +1%     
======================================
  Files         372     372           
  Lines       14612   14617    +5     
  Branches     1154    1154           
======================================
+ Hits         9062    9069    +7     
+ Misses       5343    5341    -2     
  Partials      207     207

@IanMatthewHuff
Ian Huff (IanMatthewHuff) merged commit bb129fb into microsoft:master Mar 22, 2019
@IanMatthewHuff
Ian Huff (IanMatthewHuff) deleted the dev/ianhu/runFileInteractiveFixes branch July 25, 2019 23:52
@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants