Handle failures with conda activation#4669
Merged
Merged
Conversation
| return this.parseEnvironmentOutput(result.stdout); | ||
| } catch (e) { | ||
| // Some callers want this to bubble out, others don't | ||
| if (allowExceptions) { |
Member
There was a problem hiding this comment.
The trace seems useful in either case I'd move it outside the else.
Author
There was a problem hiding this comment.
| } | ||
| } | ||
|
|
||
| return usableInterpreter ? true: false; |
Member
There was a problem hiding this comment.
usableInterpreter === undefined now doesn't throw an Error. I think we would still want one in that case.
Author
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #4669 +/- ##
=======================================
- Coverage 77% 77% -<1%
=======================================
Files 446 447 +1
Lines 21218 21490 +272
Branches 3471 3539 +68
=======================================
+ Hits 16293 16425 +132
- Misses 4921 5058 +137
- Partials 4 7 +3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #4424
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)