Enable live share support#4645
Conversation
|
|
||
| export const IJupyterExecution = Symbol('IJupyterExecution'); | ||
| export interface IJupyterExecution extends IAsyncDisposable { | ||
| sessionChanged: Event<void> ; |
There was a problem hiding this comment.
sessionChanged [](start = 4, length = 14)
This was added so that if a history window was host and then suddenly switched to guest, it would dispose of the server in use #ByDesign
Codecov Report
@@ Coverage Diff @@
## master #4645 +/- ##
=======================================
+ Coverage 77% 77% +1%
=======================================
Files 445 446 +1
Lines 21074 21126 +52
Branches 3450 3452 +2
=======================================
+ Hits 16118 16232 +114
+ Misses 4952 4890 -62
Partials 4 4
|
| return files.map(filePath => `./${filePath.slice(0, -3)}`); | ||
| } | ||
| exports.getListOfExistingModulesInOutDir = getListOfExistingModulesInOutDir; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. |
There was a problem hiding this comment.
Code flow is not showing a change in this file. What changed? #ByDesign
There was a problem hiding this comment.
Yeah there's a bunch like this. Or there's about to be. I think it's just line endings. Git will skip these on the real commit.
In reply to: 262688394 [](ancestors = 262688394)
There was a problem hiding this comment.
Sorry the 'about to be' is me ingesting a new liveshare npm module. They broke our install again with a requirement we don't minify their js.
In reply to: 262689934 [](ancestors = 262689934,262688394)
There was a problem hiding this comment.
And that means I have to rework the 'fix' for release mode again.
In reply to: 262690183 [](ancestors = 262690183,262689934,262688394)
| // Only do this once as it crashes if we ask more than once | ||
| if (!this.vscodeApi && | ||
| // tslint:disable-next-line:no-typeof-undefined | ||
| typeof acquireVsCodeApi !== 'undefined') { |
There was a problem hiding this comment.
// Comment
// tslint:
if (!this.vscodeApi && typeof acquireVsCodeApi !=== 'undefined') {
Would read better unless there was a reason to break it up. #Resolved
| runTest('Tomorrow Night Blue', true, true); | ||
|
|
||
| // One test to make sure unknown themes don't return a value. | ||
| runTest('Knight Rider', true, false); |
There was a problem hiding this comment.
I'm going to add a Knight Rider theme now... #WontFix
There was a problem hiding this comment.
| container.wrapper = mounted; | ||
|
|
||
| // We can remove the global api and event listener now. | ||
| delete (global as any)['ascquireVsCodeApi']; |
There was a problem hiding this comment.
misspell function name. #Resolved
There was a problem hiding this comment.
| assert.ok(both, 'Expected both guest and host to be used'); | ||
| await codeWatcher.runAllCells(); | ||
| }); | ||
| verifyHtmlOnCell(wrapper, '<span>1</span>', CellPosition.Last); |
There was a problem hiding this comment.
verify hostContainer.wrapper here as well? #Resolved
There was a problem hiding this comment.
changes from vsls sending out onsessionchanged more often
For #4521, #4529
Finish enabling live share support and add tests for liveshare and color parsing.
Fix issue with liveshare not bundling correctly.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)