Skip to content

Fix all typescript errors when compiled in strict mode #5#4421

Merged
karrtikr merged 14 commits into
microsoft:masterfrom
karrtikr:errors5
Mar 4, 2019
Merged

Fix all typescript errors when compiled in strict mode #5#4421
karrtikr merged 14 commits into
microsoft:masterfrom
karrtikr:errors5

Conversation

@karrtikr
Copy link
Copy Markdown

For #611 part 5

@karrtikr karrtikr added the no-changelog No news entry required label Feb 15, 2019
@karrtikr karrtikr changed the title Fix all typescript errors when compiled in strict mode #5 WIP - Fix all typescript errors when compiled in strict mode #5 Feb 16, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 16, 2019

Codecov Report

Merging #4421 into master will increase coverage by 20%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #4421     +/-   ##
========================================
+ Coverage      58%     77%    +20%     
========================================
  Files         369     445     +76     
  Lines       15946   21076   +5130     
  Branches     2507    3423    +916     
========================================
+ Hits         9134   16216   +7082     
+ Misses       6190    4854   -1336     
+ Partials      622       6    -616
Flag Coverage Δ
#Linux 65% <84%> (?)
#Windows 66% <84%> (?)
#macOS 65% <84%> (?)

@karrtikr karrtikr changed the title WIP - Fix all typescript errors when compiled in strict mode #5 Fix all typescript errors when compiled in strict mode #5 Feb 16, 2019
Co-Authored-By: karrtikr <karraj@microsoft.com>
Comment thread src/test/common/terminals/helper.unit.test.ts Outdated
Comment thread src/test/common/terminals/helper.unit.test.ts Outdated
Comment thread src/test/languageServers/jedi/pythonSignatureProvider.unit.test.ts
Copy link
Copy Markdown

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove never

@karrtikr karrtikr merged commit 35177a4 into microsoft:master Mar 4, 2019
@karrtikr karrtikr deleted the errors5 branch March 4, 2019 21:25
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants