Separate Jupyter Server #4351
Merged
IanMatthewHuff merged 30 commits intoFeb 12, 2019
Merged
Conversation
Member
Author
|
I'm going to add a functional test here for this, but getting out the initial review first to make sure that there are not larger changed needed first. |
Codecov Report
@@ Coverage Diff @@
## master #4351 +/- ##
========================================
+ Coverage 56% 78% +22%
========================================
Files 361 437 +76
Lines 15272 20301 +5029
Branches 2373 3255 +882
========================================
+ Hits 8494 15670 +7176
+ Misses 6234 4627 -1607
+ Partials 544 4 -540
|
rchiodo
reviewed
Feb 12, 2019
| const firstServer = await serverManager.getOrCreateServer(); | ||
| const secondServer = await serverManager.getOrCreateServer(); | ||
|
|
||
| // Execution should only have been called once, not twice |
There was a problem hiding this comment.
once [](start = 50, length = 4)
Comment is out of date. I believe it's called twice in this case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #4348
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)